Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API Remove deprecated code #10594

Merged
merged 1 commit into from
Dec 7, 2022
Merged

API Remove deprecated code #10594

merged 1 commit into from
Dec 7, 2022

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova mentioned this pull request Nov 28, 2022
Closed
8 tasks
@sabina-talipova sabina-talipova force-pushed the pulls/5/remove-deprecated-code branch 2 times, most recently from 5649de4 to 4a2fcda Compare December 1, 2022 03:22
@sabina-talipova
Copy link
Contributor Author

Failed CI requires asset-admin PR should be merged before

@sabina-talipova sabina-talipova force-pushed the pulls/5/remove-deprecated-code branch 2 times, most recently from c9fad42 to 7c0ffa6 Compare December 5, 2022 20:01
emteknetnz
emteknetnz requested changes Dec 5, 2022
View reviewed changes
lang/bg.yml Outdated Show resolved Hide resolved
src/Control/Director.php Outdated Show resolved Hide resolved
src/Forms/FieldList.php Outdated Show resolved Hide resolved
src/Forms/FieldList.php Outdated Show resolved Hide resolved
src/ORM/Connect/MySQLDatabase.php Show resolved Hide resolved
src/i18n/TextCollection/i18nTextCollector.php Show resolved Hide resolved
src/i18n/i18n.php Show resolved Hide resolved
tests/php/Dev/DeprecationTest.php Outdated Show resolved Hide resolved
tests/php/Dev/DeprecationTest/DeprecationTestObject.php Outdated Show resolved Hide resolved
tests/php/Logging/MonologErrorHandlerTest.php Outdated Show resolved Hide resolved
@sabina-talipova sabina-talipova force-pushed the pulls/5/remove-deprecated-code branch 3 times, most recently from 80c3638 to c231c96 Compare December 7, 2022 00:29
@sabina-talipova sabina-talipova force-pushed the pulls/5/remove-deprecated-code branch from c231c96 to 3b87605 Compare December 7, 2022 03:09
@emteknetnz emteknetnz merged commit 53c0147 into silverstripe:5 Dec 7, 2022
@emteknetnz emteknetnz deleted the pulls/5/remove-deprecated-code branch December 7, 2022 21:50
@GuySartorelli GuySartorelli mentioned this pull request Jan 10, 2023
Closed
2 tasks
@satrun77 satrun77 mentioned this pull request May 16, 2023
Merged
@GuySartorelli GuySartorelli mentioned this pull request Jan 6, 2025
Merged
GuySartorelli added a commit to creative-commoners/silverstripe-framework that referenced this pull request Jan 7, 2025
@GuySartorelli
FIX Finish removing deprecated i18n functionality.
7ae5ead 
This deprecated functionality was partially removed in silverstripe#10594. This
commit finishes the job.
@GuySartorelli GuySartorelli mentioned this pull request Jan 7, 2025
Merged
emteknetnz pushed a commit that referenced this pull request Jan 7, 2025
@GuySartorelli
FIX Finish removing deprecated i18n functionality. (#11528)
3871869 
This deprecated functionality was partially removed in #10594. This
commit finishes the job.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @emteknetnz